Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(turbopack): Migrate as many data structures to FxHash as possible #75546

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from
Open

perf(turbopack): Migrate as many data structures to FxHash as possible #75546

wants to merge 1 commit into from

Conversation

bgw
Copy link
Member

@bgw bgw commented Jan 31, 2025 •
edited
Loading

Migrate as many things as possible that I could find with:

rg '\b(Index|Hash)(Map|Set)<'

Benchmarks

I tried building next-site, differences are likely within noise threshold.

Before this change

$ hyperfine --warmup 1 --runs 5 --prepare 'rm -rf .next' 'TURBOPACK=1 TURBOPACK_BUILD=1 TURBO_ENGINE_READ_ONLY=1 pnpm next build --experimental-build-mode=compile'

Benchmark 1: TURBOPACK=1 TURBOPACK_BUILD=1 TURBO_ENGINE_READ_ONLY=1 pnpm next build --experimental-build-mode=compile
  Time (mean ± σ):     27.254 s ±  0.268 s    [User: 125.055 s, System: 16.090 s]
  Range (min … max):   26.810 s … 27.529 s    5 runs

After this change

$ hyperfine --warmup 1 --runs 5 --prepare 'rm -rf .next' 'TURBOPACK=1 TURBOPACK_BUILD=1 TURBO_ENGINE_READ_ONLY=1 pnpm next build --experimental-build-mode=compile'

Benchmark 1: TURBOPACK=1 TURBOPACK_BUILD=1 TURBO_ENGINE_READ_ONLY=1 pnpm next build --experimental-build-mode=compile
  Time (mean ± σ):     26.711 s ±  0.461 s    [User: 123.910 s, System: 15.667 s]
  Range (min … max):   26.346 s … 27.463 s    5 runs

@ijjk ijjk added created-by: Turbopack team PRs by the Turbopack team. Font (next/font) Related to Next.js Font Optimization. Turbopack Related to Turbopack with Next.js. labels Jan 31, 2025
This was referenced Jan 31, 2025
Merged
Merged
Merged
@bgw Graphite App
Copy link
Member Author

bgw commented Jan 31, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@bgw bgw mentioned this pull request Jan 31, 2025
Merged
@bgw bgw requested review from kdy1, mischnic and sokra January 31, 2025 23:39
@bgw bgw force-pushed the bgw/fx-hash-map branch from 5b1efbd to ea25113 Compare February 1, 2025 00:29
@bgw bgw marked this pull request as ready for review February 1, 2025 02:13
@bgw bgw force-pushed the bgw/fx-hash-map branch from ea25113 to b3b7513 Compare February 3, 2025 21:03
@ijjk
Copy link
Member

ijjk commented Feb 3, 2025 •
edited
Loading

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js bgw/fx-hash-map Change
buildDuration 19s 17.6s N/A
buildDurationCached 16.5s 13.8s N/A
nodeModulesSize 391 MB 391 MB ✓
nextStartRea..uration (ms) 456ms 438ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js bgw/fx-hash-map Change
5306-HASH.js gzip 54 kB 54 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 241 B 243 B N/A
main-HASH.js gzip 34.5 kB 34.4 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bgw/fx-hash-map Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 39.4 kB 39.4 kB ✓
Client Pages
vercel/next.js canary vercel/next.js bgw/fx-hash-map Change
_app-HASH.js gzip 193 B 193 B ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB ✓
edge-ssr-HASH.js gzip 265 B 265 B ✓
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.59 kB 4.58 kB N/A
index-HASH.js gzip 268 B 268 B ✓
link-HASH.js gzip 2.35 kB 2.35 kB N/A
routerDirect..HASH.js gzip 328 B 328 B ✓
script-HASH.js gzip 397 B 397 B ✓
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.59 kB 3.59 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js bgw/fx-hash-map Change
_buildManifest.js gzip 748 B 747 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js bgw/fx-hash-map Change
index.html gzip 524 B 524 B ✓
link.html gzip 539 B 538 B N/A
withRouter.html gzip 520 B 520 B ✓
Overall change 1.04 kB 1.04 kB ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js bgw/fx-hash-map Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 210 kB 210 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js bgw/fx-hash-map Change
middleware-b..fest.js gzip 670 B 663 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B ✓
Overall change 844 B 844 B ✓
Next Runtimes
vercel/next.js canary vercel/next.js bgw/fx-hash-map Change
app-page-exp...dev.js gzip 385 kB 385 kB ✓
app-page-exp..prod.js gzip 132 kB 132 kB ✓
app-page-tur..prod.js gzip 145 kB 145 kB ✓
app-page-tur..prod.js gzip 141 kB 141 kB ✓
app-page.run...dev.js gzip 372 kB 372 kB ✓
app-page.run..prod.js gzip 128 kB 128 kB ✓
app-route-ex...dev.js gzip 39.3 kB 39.3 kB ✓
app-route-ex..prod.js gzip 25.6 kB 25.6 kB ✓
app-route-tu..prod.js gzip 25.6 kB 25.6 kB ✓
app-route-tu..prod.js gzip 25.4 kB 25.4 kB ✓
app-route.ru...dev.js gzip 40.8 kB 40.8 kB ✓
app-route.ru..prod.js gzip 25.4 kB 25.4 kB ✓
dist_client_...dev.js gzip 356 B 356 B ✓
dist_client_...dev.js gzip 349 B 349 B ✓
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB ✓
pages-api.ru...dev.js gzip 11.8 kB 11.8 kB ✓
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB ✓
pages-turbo...prod.js gzip 21.9 kB 21.9 kB ✓
pages.runtim...dev.js gzip 31.5 kB 31.5 kB ✓
pages.runtim..prod.js gzip 21.9 kB 21.9 kB ✓
server.runti..prod.js gzip 60.2 kB 60.2 kB ✓
Overall change 1.65 MB 1.65 MB ✓
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js bgw/fx-hash-map Change
0.pack gzip 2.1 MB 2.11 MB ⚠️ +316 B
index.pack gzip 75.9 kB 76.1 kB ⚠️ +178 B
Overall change 2.18 MB 2.18 MB ⚠️ +494 B
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 5ba3555

@bgw bgw force-pushed the bgw/fx-hash-map branch from b3b7513 to 507fafe Compare February 3, 2025 21:55
@bgw bgw force-pushed the bgw/fxdashmap branch 2 times, most recently from 93f5112 to d33071e Compare February 4, 2025 01:41
@bgw bgw force-pushed the bgw/fx-hash-map branch from 507fafe to d48d8f2 Compare February 4, 2025 01:41
@bgw bgw force-pushed the bgw/fx-hash-map branch from d48d8f2 to fa57e8c Compare February 4, 2025 03:01
@bgw bgw force-pushed the bgw/fxdashmap branch 2 times, most recently from 75fb5ce to d09ad93 Compare February 4, 2025 03:23
@bgw bgw force-pushed the bgw/fx-hash-map branch from fa57e8c to 6ef67be Compare February 4, 2025 03:23
@bgw bgw changed the base branch from bgw/fxdashmap to graphite-base/75546 February 4, 2025 03:48
@bgw bgw force-pushed the graphite-base/75546 branch from d09ad93 to 883147a Compare February 4, 2025 03:48
@bgw bgw force-pushed the bgw/fx-hash-map branch from 6ef67be to 21ed50d Compare February 4, 2025 03:48
@bgw bgw changed the base branch from graphite-base/75546 to canary February 4, 2025 03:48
@bgw bgw force-pushed the bgw/fx-hash-map branch from 21ed50d to 5ba3555 Compare February 4, 2025 03:49
@ijjk
Copy link
Member

ijjk commented Feb 4, 2025 •
edited
Loading

Failing test suites

Commit: 5ba3555

pnpm test-dev-turbo test/development/acceptance/error-recovery.test.ts (turbopack)

  • ReactRefreshLogBox turbo > logbox: can recover from a syntax error without losing state
  • ReactRefreshLogBox turbo > render error not shown right after syntax error
Expand output

● ReactRefreshLogBox turbo › logbox: can recover from a syntax error without losing state

TIMED OUT: /Count: 1/



undefined

  735 |
  736 |   if (hardError) {
> 737 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr)
      |           ^
  738 |   }
  739 |   return false
  740 | }

  at check (lib/next-test-utils.ts:737:11)
  at Object.<anonymous> (development/acceptance/error-recovery.test.ts:66:5)

● ReactRefreshLogBox turbo › render error not shown right after syntax error

expect(received).toInclude(expected)

Expected string to include:
  "render() {"
Received:
  "./index.js:5:5
Parsing ecmascript source code failed
  3 | class ClassDefault extends React.Component {
  4 |   render()
> 5 |     return <h1>Default Export</h1>;
    |     ^^^^^^
  6 |   }
  7 | }
  8 |·
Expected '{', got 'return'"

  302 |     await session.assertHasRedbox()
  303 |
> 304 |     await expect(session.getRedboxSource()).resolves.toInclude('render() {')
      |                                                      ^
  305 |
  306 |     expect(await session.getRedboxSource()).toInclude(
  307 |       "throw new Error('nooo');"

  at Object.toInclude (../node_modules/.pnpm/[email protected]/node_modules/expect/build/index.js:174:22)
  at Object.toInclude (development/acceptance/error-recovery.test.ts:304:54)

Read more about building and testing Next.js in contributing.md.

pnpm test-dev test/e2e/socket-io/index.test.js

  • socket-io > should support socket.io without falling back to polling
Expand output

● socket-io › should support socket.io without falling back to polling

TIMED OUT: /hello world/



undefined

  735 |
  736 |   if (hardError) {
> 737 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr)
      |           ^
  738 |   }
  739 |   return false
  740 | }

  at check (lib/next-test-utils.ts:737:11)
  at Object.<anonymous> (e2e/socket-io/index.test.js:31:5)

Read more about building and testing Next.js in contributing.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdy1 kdy1 kdy1 approved these changes

@mischnic mischnic Awaiting requested review from mischnic

@sokra sokra Awaiting requested review from sokra

Assignees
No one assigned
Labels
created-by: Turbopack team PRs by the Turbopack team. Font (next/font) Related to Next.js Font Optimization. Turbopack Related to Turbopack with Next.js.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bgw @ijjk @kdy1